testability-canary
Testability and design decoupling canary — checks for tight coupling, lack of Dependency Injection (DI), hardcoded constructors, Single Responsibility Principle (SRP) violations, and mockability gaps. Triggers on keywords: "/testability-canary", "testability-canary", "testability
Install
npx skills add https://github.com/TheColliery/CoalMine/tree/main/skills/testability-canary
claude plugin marketplace add https://llmmart.ai/marketplace.json && claude plugin install hetcreep-coalmine@llmmart
git clone https://github.com/TheColliery/CoalMine.git
The skills CLI installs just this skill, for any of its supported agents. Claude Code installs the whole hetcreep/coalmine collection as a plugin from our marketplace. Git is the plain clone.
Skill manifest
Testability Canary (Decoupling & Mockability Audit)
Audit code to ensure it is decoupled, modular, and easy to cover with automated tests.
Auditing Categories
- Hardcoded Constructors — instantiating deps inside classes (
new DatabaseClient()) instead of injecting via constructor/factory (prevents mocking). - SRP Violations — a class or method doing too many distinct duties (e.g. a service that also parses JSON and formats UI).
- Static Dependencies — reliance on global static methods or Singletons that make test isolation impossible.
- Time & Environment Coupling — direct
DateTime.Now,fs, orprocess.envcalls without an abstraction layer (fragile time/path-sensitive tests). - Private Logic Gaps — complex business logic hidden in private methods that can't be tested directly (extract to testable helpers).
Per-stack patterns and the mock-strategy vocabulary: read references/checks.md before scanning.
Fix mode (choice-gated)
In Agent Context, after the report, present via ask_question:
- Apply safe refactoring: extract hardcoded initializations into constructor params (DI) + add interface definitions. Each fix: checkpoint (copy the touched file(s) aside, or use an isolated worktree — never
git stash/git commit, which can hide or include unrelated staged/unstaged user work) → record a build+test BASELINE → apply → build + tests → auto-revert only if a NEW failure appeared versus the baseline. - Let me pick: user selects specific refactoring moves.
- Report only: exit unchanged.
Grants & denials (CLASSIFY-BLOCK)
| class | step it powers | grant | on denial |
|---|---|---|---|
| read | scan coupling/DI surfaces for the categories above | Read·Grep·Glob |
refuse that file, name it — never a clean bill |
| write | Fix mode's safe-refactor apply, incl. checkpoint → baseline → build+tests → auto-revert only on a NEW failure | Edit·Bash (checkpoint/build/revert need exec) |
report the fix as NOT applied AND the checkpoint/revert as NOT available, never claim done |
Output
| file:line | coupling point | severity | finding | mock strategy |
Severity: CRITICAL (un-mockable external write/network call) · HIGH (SRP violation blocking unit testing) · MEDIUM (time/env coupling) · LOW (minor static dependency)
Files (coalmine)
-
references
-
checks.md 2.3 KB
Loading…
-
-
skill-meta.json 183 B
Loading… -
SKILL.md 2.9 KB
--- name: testability-canary description: >- Testability and design decoupling canary — checks for tight coupling, lack of Dependency Injection (DI), hardcoded constructors, Single Responsibility Principle (SRP) violations, and mockability gaps. Triggers on keywords: "/testability-canary", "testability-canary", "testability audit", "decoupling". Use when refactoring coupling, introducing DI, or making code unit-testable. --- # Testability Canary (Decoupling & Mockability Audit) <!-- SHARED:LANGUAGE_HEADER --> Audit code to ensure it is decoupled, modular, and easy to cover with automated tests. ## Auditing Categories 1. **Hardcoded Constructors** — instantiating deps inside classes (`new DatabaseClient()`) instead of injecting via constructor/factory (prevents mocking). 2. **SRP Violations** — a class or method doing too many distinct duties (e.g. a service that also parses JSON and formats UI). 3. **Static Dependencies** — reliance on global static methods or Singletons that make test isolation impossible. 4. **Time & Environment Coupling** — direct `DateTime.Now`, `fs`, or `process.env` calls without an abstraction layer (fragile time/path-sensitive tests). 5. **Private Logic Gaps** — complex business logic hidden in private methods that can't be tested directly (extract to testable helpers). Per-stack patterns and the mock-strategy vocabulary: read `references/checks.md` before scanning. ## Fix mode (choice-gated) In Agent Context, after the report, present via `ask_question`: - **Apply safe refactoring:** extract hardcoded initializations into constructor params (DI) + add interface definitions. Each fix: checkpoint (copy the touched file(s) aside, or use an isolated worktree — never `git stash`/`git commit`, which can hide or include unrelated staged/unstaged user work) → record a build+test BASELINE → apply → build + tests → auto-revert only if a NEW failure appeared versus the baseline. - **Let me pick:** user selects specific refactoring moves. - **Report only:** exit unchanged. ## Grants & denials (CLASSIFY-BLOCK) | class | step it powers | grant | on denial | |---|---|---|---| | read | scan coupling/DI surfaces for the categories above | `Read`·`Grep`·`Glob` | refuse that file, name it — never a clean bill | | write | Fix mode's safe-refactor apply, incl. checkpoint → baseline → build+tests → auto-revert only on a NEW failure | `Edit`·`Bash` (checkpoint/build/revert need exec) | report the fix as NOT applied AND the checkpoint/revert as NOT available, never claim done | <!-- SHARED:CLASSIFY_BLOCK --> ## Output `| file:line | coupling point | severity | finding | mock strategy |` Severity: CRITICAL (un-mockable external write/network call) · HIGH (SRP violation blocking unit testing) · MEDIUM (time/env coupling) · LOW (minor static dependency) <!-- SHARED:REPORTING_FOOTER --> <!-- SHARED:ORCHESTRATION --> <!-- SHARED:ESCALATION_FOOTER -->
Comments (0)
Sign in to join the conversation.
Reviews (0)
No reviews yet.
No comments yet.